Issue 506037: Improve performance of allocating closures for nested...

Issue 506037: Improve performance of allocating closures for nested... (Closed)

Created:
11 years ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bakster, bak, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve performance of allocating closures for nested functions by allocating them in new space without entering the runtime system. Committed: http://code.google.com/p/v8/source/detail?r=3477

Patch Set 2 : '' #

Total comments: 3

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -35 lines)			Patch
M	bleeding_edge/src/code-stubs.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	bleeding_edge/src/codegen.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	bleeding_edge/src/factory.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	bleeding_edge/src/factory.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	bleeding_edge/src/heap.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	bleeding_edge/src/heap.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	bleeding_edge/src/ia32/codegen-ia32.cc	View	1	2 chunks	+63 lines, -10 lines	2 comments	Download
M	bleeding_edge/src/ia32/stub-cache-ia32.cc	View		1 chunk	+19 lines, -2 lines	0 comments	Download
M	bleeding_edge/src/objects.h	View		2 chunks	+6 lines, -3 lines	1 comment	Download
M	bleeding_edge/src/objects.cc	View		5 chunks	+10 lines, -4 lines	0 comments	Download
M	bleeding_edge/src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	bleeding_edge/src/runtime.cc	View		4 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bakster

LGTM, Lars http://codereview.chromium.org/506037/diff/4001/5003 File bleeding_edge/src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/506037/diff/4001/5003#newcode3599 bleeding_edge/src/ia32/codegen-ia32.cc:3599: // space when for nested functions that ...

11 years ago (2009-12-16 15:40:38 UTC) #2

Mads Ager (chromium)

11 years ago (2009-12-16 16:13:24 UTC) #3

Looks great!  A couple of drive-by nits.

http://codereview.chromium.org/506037/diff/4001/5003
File bleeding_edge/src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/506037/diff/4001/5003#newcode3598
bleeding_edge/src/ia32/codegen-ia32.cc:3598: // Use the fast case closure
allocation code that allocated in new
allocated -> allocates

http://codereview.chromium.org/506037/diff/4001/5007
File bleeding_edge/src/objects.h (right):

http://codereview.chromium.org/506037/diff/4001/5007#newcode1807
bleeding_edge/src/objects.h:1807: return( descriptor_number << 1) + 1;
Not your code, but move parenthesis.

Expand Messages | Collapse Messages