Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 506026: wm: Make _NET_ACTIVE_WINDOW contain transient windows. (Closed)

Created:
11 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

wm: Make _NET_ACTIVE_WINDOW contain transient windows. We previously only stored "toplevel" (i.e. maximized) windows in this hint, but storing transients there when they have the focus will hopefully get along better with Chrome's info bubble implementation. Intended to fix http://code.google.com/p/chromium-os/issues/detail?id=1012.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/platform/window_manager/layout_manager.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/platform/window_manager/layout_manager_test.cc View 13 chunks +18 lines, -16 lines 0 comments Download
M src/platform/window_manager/panel_bar_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
11 years ago (2009-12-16 03:54:37 UTC) #1
sky
11 years ago (2009-12-16 16:34:37 UTC) #2
This worked good for me in my testing.

LGTM

Powered by Google App Engine
This is Rietveld 408576698