Issue 5060001: DOMUI: Pixel-perfect CSS fixes.

Issue 5060001: DOMUI: Pixel-perfect CSS fixes. (Closed)

Created:
10 years, 1 month ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Pixel-perfect CSS fixes. * Alphabetized CSS attributes. * Matching colors for titles. * Header of first title is 70px from top. * 20px between sections. * 10px between some input elements (not all fixed). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66212

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes. #

Patch Set 3 : One more nit. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -35 lines)			Patch
	M	chrome/browser/resources/options/options_page.css	View	1 2	11 chunks	+33 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

http://codereview.chromium.org/5060001/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/5060001/diff/1/chrome/browser/resources/options/options_page.css#newcode10 chrome/browser/resources/options/options_page.css:10: font-size: 185%; Per discussion, this should stay at 200% ...

10 years, 1 month ago (2010-11-16 00:21:00 UTC) #2

James Hawkins

10 years, 1 month ago (2010-11-16 00:59:11 UTC) #3

LGTM

Expand Messages | Collapse Messages