Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome_frame/module_utils.cc

Issue 5057007: Remove a DCHECK when failing to secure the shared memory used to hold the cur... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/module_utils.cc
===================================================================
--- chrome_frame/module_utils.cc (revision 66270)
+++ chrome_frame/module_utils.cc (working copy)
@@ -148,9 +148,10 @@
if (result) {
// We created the beacon, now we need to mutate the security attributes
// on the shared memory to allow read-only access and let low-integrity
- // processes open it.
- bool acls_set = SetFileMappingToReadOnly(shared_memory_->handle());
- DCHECK(acls_set);
+ // processes open it. This will fail on FAT32 file systems.
+ if (!SetFileMappingToReadOnly(shared_memory_->handle())) {
+ DLOG(ERROR) << "Failed to set file mapping permissions.";
+ }
} else {
created_beacon = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698