Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 5057005: Revert "Reworked devserver so that update images generated are cached in directories named after" (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov, dgarrett
CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis
Visibility:
Public.

Description

Revert "Reworked devserver so that update images generated are cached in directories named after" This reverts commit 710470d0108fa170122682d68fb0b5f810441c3d. BUG=chromium-os:9215 TEST=na Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=de91f67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -172 lines) Patch
M autoupdate.py View 15 chunks +108 lines, -141 lines 0 comments Download
M autoupdate_unittest.py View 4 chunks +10 lines, -11 lines 0 comments Download
M devserver.py View 5 chunks +3 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
Hey Don, I'm reverting your change for now to get image_to_live working again and to ...
10 years, 1 month ago (2010-11-16 18:05:30 UTC) #1
dgarrett
10 years, 1 month ago (2010-11-16 19:57:22 UTC) #2
  I'm trying to figure out why. I ran ctest successfully on my machine,
though didn't repeat it though all of the later rounds of revisions.

On Tue, Nov 16, 2010 at 10:05 AM, <sosa@chromium.org> wrote:

> Reviewers: dgarrett, petkov,
>
> Message:
> Hey Don,
>
> I'm reverting your change for now to get image_to_live working again and to
> hopefully fix ctest for the next round of builders.
>
> It seems like the underlying issue is that stateful_update doesn't get
> communicated the cache path.  One possible way to fix this is to symlink
> the
> newest cached file to the base of the static dir.
>
> Description:
> Revert "Reworked devserver so that update images generated are cached in
> directories named after"
>
> This reverts commit 710470d0108fa170122682d68fb0b5f810441c3d.
>
> BUG=chromium-os:9215
> TEST=na
>
> Please review this at http://codereview.chromium.org/5057005/
>
> SVN Base: http://git.chromium.org/git/dev-util.git@master
>
> Affected files:
>  M autoupdate.py
>  M autoupdate_unittest.py
>  M devserver.py
>
>
>


-- 
Don

Powered by Google App Engine
This is Rietveld 408576698