Issue 5056003: Retry in parallel_emerge for 5xx error codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5056003: Retry in parallel_emerge for 5xx error codes. (Closed)

Created:
10 years, 1 month ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
petkov, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Retry in parallel_emerge for 5xx error codes. When the server returns a 5xx error code, we should retry. Such errors are often due to flakiness, so retries resolve the issue. BUG=chromium-os:9217 TEST=Tested parallel_emerge with fake URL to verify it retries. Change-Id: Ie5cf003562b5261005be9929624769394b4802a1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8ce0100

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add sleeps in between retries per petkov's comments. #

Patch Set 3 : Address sosa's comments. #

Patch Set 4 : Add explicit conversion for better error messages. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	parallel_emerge	View	1 2 3	2 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

http://codereview.chromium.org/5056003/diff/1/parallel_emerge File parallel_emerge (right): http://codereview.chromium.org/5056003/diff/1/parallel_emerge#newcode686 parallel_emerge:686: if i + 1 == tries or e.code < ...

10 years, 1 month ago (2010-11-16 18:09:25 UTC) #2

petkov

10 years, 1 month ago (2010-11-16 18:17:33 UTC) #3

LGTM but you should change == tries to >= tries. And you may want to change "i"
to "try". Thanks!

Expand Messages | Collapse Messages