Issue 505025: Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505025: Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked (Closed)

Created:
11 years ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked Committed: http://code.google.com/p/v8/source/detail?r=3634

Patch Set 4 : merge and simplify sample script #

Patch Set 7 : rollback formatting #

Patch Set 11 : rollback test #

Total comments: 2

Patch Set 12 : follow codereview #

Patch Set 13 : move debug command back #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -8 lines)			Patch
M	include/v8-debug.h	View	4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/api.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/debug.h	View	1 2 3 4 5 6 7 8	5 chunks	+30 lines, -1 line	0 comments	Download
M	src/debug.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	5 chunks	+71 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/505025/diff/14002/15009 File src/debug.cc (right): http://codereview.chromium.org/505025/diff/14002/15009#newcode2776 src/debug.cc:2776: sem_(OS::CreateSemaphore(0)), mutex_(OS::CreateMutex()), already_signalled_(false) { Long line.

10 years, 11 months ago (2010-01-18 10:32:21 UTC) #2

Peter Rybin

10 years, 11 months ago (2010-01-18 15:38:12 UTC) #3

I fixed formatting.

Also I realized that I should put back "StackGuard::DebugCommand();"
It was that with my new option I wait for Locker and only after this set
DebugCommand.
Now I put it back and it sets DebugCommand right when message arrives.

http://codereview.chromium.org/505025/diff/14002/15009
File src/debug.cc (right):

http://codereview.chromium.org/505025/diff/14002/15009#newcode2776
src/debug.cc:2776: sem_(OS::CreateSemaphore(0)), mutex_(OS::CreateMutex()),
already_signalled_(false) {
On 2010/01/18 10:32:21, Søren Gjesse wrote:
> Long line.

Done.

Expand Messages | Collapse Messages

Issue 505025: Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked (Closed)

Description

Patch Set 1 #

Patch Set 2 : clean-up #

Patch Set 3 : comments #

Patch Set 4 : merge and simplify sample script #

Patch Set 5 : merge #

Patch Set 6 : merge #

Patch Set 7 : rollback formatting #

Patch Set 8 : redo mutex #

Patch Set 9 : format #

Patch Set 10 : clean-up #

Patch Set 11 : rollback test #

Patch Set 12 : follow codereview #

Patch Set 13 : move debug command back #

Messages