Issue 505022: Convert a crash to a NOTREACHED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505022: Convert a crash to a NOTREACHED. (Closed)

Created:
11 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Win: Fix an invalid handle initialization in the spellchecker. Also, convert a potential crash to a NOTREACHED. BUG=30433 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34902

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View	1 2 3	4 chunks	+19 lines, -7 lines	0 comments	Download
M	ipc/ipc_platform_file.h	View	2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

found the crash (see browser_render_process_host.cc and ipc_platform_file.h). I would still like to add the extra ...

11 years ago (2009-12-17 22:04:42 UTC) #1

huanr

LGTM http://codereview.chromium.org/505022/diff/3003/3005 File chrome/browser/renderer_host/browser_render_process_host.cc (left): http://codereview.chromium.org/505022/diff/3003/3005#oldcode983 chrome/browser/renderer_host/browser_render_process_host.cc:983: IPC::PlatformFileForTransit(), What does IPC::PlatformFileForTransit() end up being with?

11 years ago (2009-12-18 00:01:40 UTC) #2

Evan Stade

11 years ago (2009-12-18 00:10:06 UTC) #3

http://codereview.chromium.org/505022/diff/3003/3005
File chrome/browser/renderer_host/browser_render_process_host.cc (left):

http://codereview.chromium.org/505022/diff/3003/3005#oldcode983
chrome/browser/renderer_host/browser_render_process_host.cc:983:
IPC::PlatformFileForTransit(),
On 2009/12/18 00:01:40, huanr wrote:
> What does IPC::PlatformFileForTransit() end up being with?

on windows, this was 0 instead of -1. On Posix it was -1 (see
base/file_descriptor_posix)

Expand Messages | Collapse Messages