Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 505012: Fix regression where we stopped running content scripts in (Closed)

Created:
11 years ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix regression where we stopped running content scripts in extension processes. BUG=29621

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -36 lines) Patch
A chrome/browser/extensions/content_script_extension_process_apitest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/child_process_logging.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_win.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 chunks +24 lines, -3 lines 1 comment Download
M chrome/renderer/user_script_slave.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/user_script_slave.cc View 2 chunks +15 lines, -15 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_script_extension_process/background.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years ago (2009-12-16 00:16:16 UTC) #1
Matt Perry
11 years ago (2009-12-16 00:23:58 UTC) #2
LGTM

http://codereview.chromium.org/505012/diff/1001/1010
File chrome/renderer/extensions/extension_process_bindings.cc (right):

http://codereview.chromium.org/505012/diff/1001/1010#newcode137
chrome/renderer/extensions/extension_process_bindings.cc:137: LOG(ERROR) << log;
Did you mean to keep this log here (and as ERROR)?

Powered by Google App Engine
This is Rietveld 408576698