Issue 5047002: Sync: Fix RequestResume in SyncerThread, and re-enable the various unit tests...

Issue 5047002: Sync: Fix RequestResume in SyncerThread, and re-enable the various unit tests... (Closed)

Created:
10 years, 1 month ago by Nicolas Zea

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, ben+cc_chromium.org, Paweł Hajdan Jr., Nicolas Zea

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Sync: Fix RequestResume in SyncerThread, and re-enable the various unit tests that were breaking. BUG=62880, 39070, 62880 TEST=sync_unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66507

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -16 lines)			Patch
	M	chrome/browser/sync/engine/syncer_thread.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/sync/engine/syncer_thread_unittest.cc	View	1 2 3 4	4 chunks	+9 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

Looks like they're working now (hopefully!). I ran everything under tsan for 20 iterations on ...

10 years, 1 month ago (2010-11-16 21:12:36 UTC) #1

Nicolas Zea

Forgot to add reviewers apparently. Previous message: Looks like they're working now (hopefully!). I ran ...

10 years, 1 month ago (2010-11-16 21:23:39 UTC) #2

tim (not reviewing)

Please add bug 39070 and 62880 to the BUG= Thanks for taking a stab at ...

10 years, 1 month ago (2010-11-16 23:45:24 UTC) #3

Nicolas Zea

http://codereview.chromium.org/5047002/diff/8001/chrome/browser/sync/engine/syncer_thread.cc File chrome/browser/sync/engine/syncer_thread.cc (right): http://codereview.chromium.org/5047002/diff/8001/chrome/browser/sync/engine/syncer_thread.cc#newcode206 chrome/browser/sync/engine/syncer_thread.cc:206: vault_.pause_requested_ = false; On 2010/11/16 23:45:24, timsteele wrote: > ...

10 years, 1 month ago (2010-11-17 02:02:48 UTC) #4

tim (not reviewing)

10 years, 1 month ago (2010-11-17 19:57:50 UTC) #5

On 2010/11/17 02:02:48, nzea wrote:
>
http://codereview.chromium.org/5047002/diff/8001/chrome/browser/sync/engine/s...
> File chrome/browser/sync/engine/syncer_thread.cc (right):
> 
>
http://codereview.chromium.org/5047002/diff/8001/chrome/browser/sync/engine/s...
> chrome/browser/sync/engine/syncer_thread.cc:206: vault_.pause_requested_ =
> false;
> On 2010/11/16 23:45:24, timsteele wrote:
> > vault_field_changed_.Signal()?
> 
> Done. Wasn't sure if that was necessary, but it seems more consistent to have
it
> there.

LGTM

Expand Messages | Collapse Messages