Issue 5047001: Remove flaky marker from nacl_sandbox_test now that it is fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5047001: Remove flaky marker from nacl_sandbox_test now that it is fixed. (Closed)

Created:
10 years, 1 month ago by jvoung - send to chromium...

Modified:
9 years, 7 months ago

Reviewers:
nsylvain

CC:
chromium-reviews, native-client-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove flaky marker from nacl_sandbox_test now that it is fixed. BUG=50121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66216

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/test/nacl/nacl_sandbox_test.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 1 month ago (2010-11-16 01:54:32 UTC) #2

LGTM

On Mon, Nov 15, 2010 at 1:55 PM, <jvoung@google.com> wrote:

> Reviewers: nsylvain,
>
> Description:
> Remove flaky marker from nacl_sandbox_test now that it is fixed.
>
> BUG=50121
>
>
> Please review this at http://codereview.chromium.org/5047001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/nacl/nacl_sandbox_test.cc
>
>
> Index: chrome/test/nacl/nacl_sandbox_test.cc
> ===================================================================
> --- chrome/test/nacl/nacl_sandbox_test.cc       (revision 66118)
> +++ chrome/test/nacl/nacl_sandbox_test.cc       (working copy)
> @@ -36,8 +36,7 @@
>  NaClSandboxTest::~NaClSandboxTest() {
>  }
>
> -// http://crbug.com/50121
> -TEST_F(NaClSandboxTest, FLAKY_NaClOuterSBTest) {
> +TEST_F(NaClSandboxTest, NaClOuterSBTest) {
>   // Load a helloworld .nexe to trigger the nacl loader test.
>   FilePath test_file(kSrpcHwHtmlFileName);
>   RunTest(test_file, action_max_timeout_ms());
>
>
>

Expand Messages | Collapse Messages