Issue 5045005: Clean-up, not returning anything in InstantController void method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5045005: Clean-up, not returning anything in InstantController void method. (Closed)

Created:
10 years, 1 month ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean-up, not returning anything in void returning method. BUG=NONE TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66360

Patch Set 2 : Synced #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	chrome/browser/instant/instant_controller.cc	View		3 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/5045005/diff/1/chrome/browser/instant/instant_controller.cc File chrome/browser/instant/instant_controller.cc (right): http://codereview.chromium.org/5045005/diff/1/chrome/browser/instant/instant_controller.cc#newcode280 chrome/browser/instant/instant_controller.cc:280: return; no return here.

10 years, 1 month ago (2010-11-17 00:02:35 UTC) #2

Jay Civelli

http://codereview.chromium.org/5045005/diff/1/chrome/browser/instant/instant_controller.cc File chrome/browser/instant/instant_controller.cc (right): http://codereview.chromium.org/5045005/diff/1/chrome/browser/instant/instant_controller.cc#newcode280 chrome/browser/instant/instant_controller.cc:280: return; On 2010/11/17 00:02:35, sky wrote: > no return ...

10 years, 1 month ago (2010-11-17 00:11:08 UTC) #3