chrome/test/functional/find_in_page.py - Issue 5044001: Fix FindMatchTests.testSearchWithinSpecialURL test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/find_in_page.py

Issue 5044001: Fix FindMatchTests.testSearchWithinSpecialURL test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/functional

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/functional/find_in_page.py

diff --git a/chrome/test/functional/find_in_page.py b/chrome/test/functional/find_in_page.py

index b925a65c8a5cf789395564f566887b78f6a01d78..4ac0794b6d80f31719858b14cbc087c484db06fa 100644

--- a/chrome/test/functional/find_in_page.py

+++ b/chrome/test/functional/find_in_page.py

@@ -87,10 +87,12 @@ class FindMatchTests(pyauto.PyUITest):

# search in History page

self.AppendTab(pyauto.GURL('chrome://history'))

# the contents in the history page load asynchronously after tab loads

+ data_dir_suffix = 'chrome/test/data'

Nirnimesh 2010/11/15 22:05:38 nit: how about "search_string"?

dyu1 2010/11/15 22:57:01 I don't think this will work on Win because of the

kkania 2010/11/15 22:58:53 changed to search_query

kkania 2010/11/15 22:58:53 good catch, using os.path.join now

self.WaitUntil(

- lambda: self.FindInPage('data', tab_index=1)['match_count'],

+ lambda: self.FindInPage(data_dir_suffix, tab_index=1)['match_count'],

expect_retval=1)

- self.assertEqual(1, self.FindInPage('data', tab_index=1)['match_count'])

+ self.assertEqual(

+ 1, self.FindInPage(data_dir_suffix, tab_index=1)['match_count'])

# search in Downloads page

test_utils.DownloadFileFromDownloadsDataDir(self, zip_file)

self.AppendTab(pyauto.GURL('chrome://downloads'))

« no previous file with comments | « no previous file | no next file » | no next file with comments »