Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 5044001: Fix FindMatchTests.testSearchWithinSpecialURL test. (Closed)

Created:
10 years, 1 month ago by kkania
Modified:
9 years, 7 months ago
Reviewers:
dyu1, Nirnimesh
CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix FindMatchTests.testSearchWithinSpecialURL test. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66576

Patch Set 1 #

Total comments: 4

Patch Set 2 : Change var name and use os.path.join #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/test/functional/find_in_page.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kkania
The test was failing on the linux bot because the bot's path to the data ...
10 years, 1 month ago (2010-11-15 21:54:18 UTC) #1
Nirnimesh
LGTM. Thanks for figuring this out. http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py File chrome/test/functional/find_in_page.py (right): http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py#newcode90 chrome/test/functional/find_in_page.py:90: data_dir_suffix = 'chrome/test/data' ...
10 years, 1 month ago (2010-11-15 22:05:38 UTC) #2
dyu1
http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py File chrome/test/functional/find_in_page.py (right): http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py#newcode90 chrome/test/functional/find_in_page.py:90: data_dir_suffix = 'chrome/test/data' I don't think this will work ...
10 years, 1 month ago (2010-11-15 22:57:01 UTC) #3
kkania
http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py File chrome/test/functional/find_in_page.py (right): http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_page.py#newcode90 chrome/test/functional/find_in_page.py:90: data_dir_suffix = 'chrome/test/data' On 2010/11/15 22:05:38, Nirnimesh wrote: > ...
10 years, 1 month ago (2010-11-15 22:58:53 UTC) #4
dyu1
10 years, 1 month ago (2010-11-15 23:02:27 UTC) #5
On 2010/11/15 22:58:53, kkania wrote:
>
http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_...
> File chrome/test/functional/find_in_page.py (right):
> 
>
http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_...
> chrome/test/functional/find_in_page.py:90: data_dir_suffix =
'chrome/test/data'
> On 2010/11/15 22:05:38, Nirnimesh wrote:
> > nit: how about "search_string"?
> 
> changed to search_query
> 
>
http://codereview.chromium.org/5044001/diff/1/chrome/test/functional/find_in_...
> chrome/test/functional/find_in_page.py:90: data_dir_suffix =
'chrome/test/data'
> On 2010/11/15 22:57:01, dyu1 wrote:
> > I don't think this will work on Win because of the back slash.
> 
> good catch, using os.path.join now

LGTM

Powered by Google App Engine
This is Rietveld 408576698