Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 5042001: Put the parentheses back where they belong in time_mac.cc (Closed)

Created:
10 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, John Grabowski
Visibility:
Public.

Description

Put the parentheses back where they belong in time_mac.cc. This will allow Aaron's new test in http://codereview.chromium.org/4471001 to pass. BUG=49233 TEST=base_unittests Time.FromExplodedWithMilliseconds from http://codereview.chromium.org/4471001 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/time_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
This was correct when I initially wrote it, but someone added some parentheses in the ...
10 years, 1 month ago (2010-11-15 21:11:27 UTC) #1
Aaron Boodman
Awesome. LGTM.
10 years, 1 month ago (2010-11-15 21:27:45 UTC) #2
Aaron Boodman
Do you want to submit this? If so, you should put my test into this ...
10 years, 1 month ago (2010-11-15 21:28:33 UTC) #3
Mark Mentovai
10 years, 1 month ago (2010-11-15 21:39:33 UTC) #4
Yeah, I submitted this one because it works as a standalone. Your test
should pass on the Mac when you add it now.

Powered by Google App Engine
This is Rietveld 408576698