Issue 5041001: Fix cross-device link errors by using shutil.move instead of os.rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5041001: Fix cross-device link errors by using shutil.move instead of os.rename (Closed)

Created:
10 years, 1 month ago by Dale Curtis

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, ericli

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git@master

Visibility:
Public.

Description

With the upcoming changes to make /home/autotest a mount pt for /mnt/stateful_partition/autotest, using os.rename in logging_CrashSender causes "OSError: [Errno 18] Invalid cross-device link". I've switched these calls to use shutil.move instead. Change-Id: I554b27e4c649867481e9aee76bd752ca90dcf582 BUG=chromium-os:8336 TEST=Ran test with new framework. Verified pass. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=497c2cb

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	client/bin/site_crash_test.py	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM - though I think there may also be similar logic in KernelCrashServer.

10 years, 1 month ago (2010-11-16 21:28:13 UTC) #2

Dale Curtis

10 years, 1 month ago (2010-11-16 21:41:08 UTC) #3

Only found one other instance of os.rename -- in logging_UserCrash which is
unaffected. Don't see anything in KernelCrashServer which should be a problem.
Pushing.

On 2010/11/16 21:28:13, kmixter1 wrote:
> LGTM - though I think there may also be similar logic in KernelCrashServer.

Expand Messages | Collapse Messages