Issue 504073: Optimize sine and cosine by checking up front if the fsin or fcos...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504073: Optimize sine and cosine by checking up front if the fsin or fcos... (Closed)

Created:
11 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize sine and cosine by checking up front if the fsin or fcos operation can throw an exception. Committed: http://code.google.com/p/v8/source/detail?r=3506

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	src/ia32/codegen-ia32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/ia32/codegen-ia32.cc	View	1	3 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/504073/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/504073/diff/1/2#newcode5397 src/ia32/codegen-ia32.cc:5397: const uint32_t too_big_exponent = Change to static const ...

11 years ago (2009-12-21 11:56:48 UTC) #2

Mads Ager (chromium)

11 years ago (2009-12-21 12:02:56 UTC) #3

Thanks!

http://codereview.chromium.org/504073/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/504073/diff/1/2#newcode5397
src/ia32/codegen-ia32.cc:5397: const uint32_t too_big_exponent =
On 2009/12/21 11:56:48, Kasper Lund wrote:
> Change to static const uint32_t kTooBigExponent and share with other code that
> uses it?

Done.

Expand Messages | Collapse Messages

Issue 504073: Optimize sine and cosine by checking up front if the fsin or fcos... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages