Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 504057: Improve code generated for left shifts where the left side... (Closed)

Created:
11 years ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Improve code generated for left shifts where the left side is a constant by avoiding a few checks. Committed: http://code.google.com/p/v8/source/detail?r=3495

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M bleeding_edge/src/ia32/codegen-ia32.cc View 1 1 chunk +36 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years ago (2009-12-18 12:27:15 UTC) #1
Erik Corry
11 years ago (2009-12-18 13:05:23 UTC) #2
LGTM.  Do our tests cover all the fun little cases?

Powered by Google App Engine
This is Rietveld 408576698