Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 5038004: Fix a browser crash when an extension with multiple active pages crashes. (Closed)

Created:
10 years, 1 month ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix a browser crash when an extension with multiple active pages crashes. BUG=63038 TEST=Install an extension with a bg page and a popup. Right-click the browser action and inspect the popup. In the task manager, kill the extension process. The browser should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/extensions/extensions_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
10 years, 1 month ago (2010-11-16 22:36:53 UTC) #1
Erik does not do reviews
10 years, 1 month ago (2010-11-16 22:54:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698