Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 5035002: Original change: http://codereview.chromium.org/4856003/ (Closed)

Created:
10 years, 1 month ago by bulach
Modified:
9 years, 7 months ago
Reviewers:
Kristian_
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Original change: http://codereview.chromium.org/4856003/ (landing on behalf of kristianm) Suppress Android warnings Android generates warnings for comparing signed and unsigned numbers. The ones in this CL should be safe. BUG=62949 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/file_util_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bulach
10 years, 1 month ago (2010-11-16 20:38:15 UTC) #1
Kristian_
LGTM, thanks Marcus!
10 years, 1 month ago (2010-11-17 11:01:22 UTC) #2
Kristian_
10 years, 1 month ago (2010-11-17 11:02:30 UTC) #3
Kristian_
10 years, 1 month ago (2010-11-17 11:04:03 UTC) #4
On 2010/11/17 11:02:30, Kristian_ wrote:

BTW, Steve created this bug to track this:
http://code.google.com/p/chromium/issues/detail?id=62949

Powered by Google App Engine
This is Rietveld 408576698