Issue 503085: Fix a typo in scm.GIT.GetBranch() and add --dry_run to trychange.py to ease testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503085: Fix a typo in scm.GIT.GetBranch() and add --dry_run to trychange.py to ease testing. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a typo in scm.GIT.GetBranch() and add --dry_run to trychange.py to ease testing. TEST=none BUG=none

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	trychange.py	View		5 chunks	+22 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

11 years ago (2009-12-22 18:05:53 UTC) #2

LGTM

http://codereview.chromium.org/503085/diff/1/3
File trychange.py (right):

http://codereview.chromium.org/503085/diff/1/3#newcode494
trychange.py:494: if not options.dry_run:
Might be worth moving this up into the http/svn handlers, that way you could say
which method for upload is being used?

Expand Messages | Collapse Messages