Issue 503068: Make breakpad, gcl and presubmit_support dependencies optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503068: Make breakpad, gcl and presubmit_support dependencies optional (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Make breakpad, gcl and presubmit_support dependencies optional TEST=unit tests

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -79 lines)			Patch
M	gcl.py	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	gclient_utils.py	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	tests/trychange_unittest.py	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	trychange.py	View	1 2	13 chunks	+51 lines, -71 lines	0 comments	Download

Total messages: 3 (0 generated)

M-A Ruel

Remove even more dependencies. Has the side-effect of disabling http transport for git-try, looking into ...

11 years ago (2009-12-19 21:06:54 UTC) #1

M-A Ruel

git-try still work because of a hack in it, will unhack later. Fixed the spurious ...

11 years ago (2009-12-19 21:48:12 UTC) #2

LGTM!