Issue 503042: Optimize the allocation of small, non-nested literal...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503042: Optimize the allocation of small, non-nested literal... (Closed)

Created:
11 years ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bakster, bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize the allocation of small, non-nested literal arrays and argument objects on IA-32. Committed: http://code.google.com/p/v8/source/detail?r=3485

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -12 lines)			Patch
M	bleeding_edge/src/code-stubs.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	bleeding_edge/src/codegen.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	bleeding_edge/src/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	bleeding_edge/src/heap.cc	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	bleeding_edge/src/ia32/codegen-ia32.cc	View	1	3 chunks	+127 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bakster

11 years ago (2009-12-17 15:24:13 UTC) #3

LGTM, Hr. Stub Writer,
  Lars

http://codereview.chromium.org/503042/diff/1/2
File bleeding_edge/src/heap.cc (right):

http://codereview.chromium.org/503042/diff/1/2#newcode2268
bleeding_edge/src/heap.cc:2268: ASSERT(object_size == JSObject::kHeaderSize + 2
* kPointerSize);
How about using a constant instead of retrieving it from the map. Keep the
ASSERT extracting the instance_size from the map.

http://codereview.chromium.org/503042/diff/1/3
File bleeding_edge/src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/503042/diff/1/3#newcode6647
bleeding_edge/src/ia32/codegen-ia32.cc:6647: ? FixedArray::kHeaderSize +
(length_ * kPointerSize)
FixedArray::SizeFor(length_)

Expand Messages | Collapse Messages