Issue 5027001: Add the Chrome version as one of the things we check to see if...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5027001: Add the Chrome version as one of the things we check to see if... (Closed)

Created:
10 years, 1 month ago by Jói

Modified:
9 years, 7 months ago

Reviewers:
twiz, Jeff Timanus

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the Chrome version as one of the things we check to see if we should attempt re-install. This helps robustness e.g. in the case where we change profile directories (as we recently did). Mark a test that I noticed was flaky (and open a bug for it). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66180

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -8 lines)			Patch
M	ceee/ie/common/ceee_module_util.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ceee/ie/common/ceee_module_util.cc	View	4 chunks	+27 lines, -3 lines	2 comments	Download
M	ceee/ie/common/ceee_module_util_unittest.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

twiz

10 years, 1 month ago (2010-11-15 19:02:48 UTC) #2

LGTM.

Just some small observations.

Jeff

http://codereview.chromium.org/5027001/diff/1/ceee/ie/common/ceee_module_util.cc
File ceee/ie/common/ceee_module_util.cc (right):

http://codereview.chromium.org/5027001/diff/1/ceee/ie/common/ceee_module_util...
ceee/ie/common/ceee_module_util.cc:22: #define LSTRINGIZE(x) LSTRINGIZE2(x)
Bummer.  Surprising that there wouldn't be common routines for this.

http://codereview.chromium.org/5027001/diff/1/ceee/ie/common/ceee_module_util...
ceee/ie/common/ceee_module_util.cc:227: LSTRINGIZE(CHROME_VERSION_STRING));
Add a DCHECK here too?

Expand Messages | Collapse Messages