Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: chrome/browser/resources/options.html

Issue 5025001: Removed Labs section from Chrome OS settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added labs to about:flags page Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/options/options_ui.cc ('k') | chrome/browser/resources/options/chromeos_labs.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options.html
diff --git a/chrome/browser/resources/options.html b/chrome/browser/resources/options.html
index f28de4fe49998450be6854f9ed8a4eaac40a81c5..a486bd3fff5e678ab1f2c286f2a7edeb5e77c6b5 100644
--- a/chrome/browser/resources/options.html
+++ b/chrome/browser/resources/options.html
@@ -193,36 +193,6 @@ function load() {
OptionsPage.registerOverlay(ImportDataOverlay.getInstance());
OptionsPage.registerOverlay(InstantConfirmOverlay.getInstance());
arv (Not doing code reviews) 2010/11/15 20:55:20 I don't understand why you are removing these?
whywhat 2010/11/15 21:03:29 I'm removing Labs section under chrome://settings.
- if (cr.isChromeOS) {
- OptionsPage.register(AccountsOptions.getInstance());
- var labsOptions = new OptionsPage('labs',
- localStrings.getString('labsPage'),
- 'labsPage');
- OptionsPage.register(labsOptions);
zel 2010/11/15 22:03:14 only 198-201 should be removed here, the rest of t
whywhat 2010/11/15 22:41:50 Ok, I guess my assumption that registerSubPage mea
- OptionsPage.registerSubPage(LanguageOptions.getInstance());
- OptionsPage.registerSubPage(new OptionsPage(
- 'languageChewing',
- localStrings.getString('languageChewingPage'),
- 'languageChewingPage'));
- OptionsPage.registerSubPage(new OptionsPage(
- 'languageHangul',
- localStrings.getString('languageHangulPage'),
- 'languageHangulPage'));
- OptionsPage.registerSubPage(new OptionsPage(
- 'languageMozc',
- localStrings.getString('languageMozcPage'),
- 'languageMozcPage'));
- OptionsPage.registerSubPage(new OptionsPage(
- 'languagePinyin',
- localStrings.getString('languagePinyinPage'),
- 'languagePinyinPage'));
- OptionsPage.registerSubPage(ProxyOptions.getInstance());
- OptionsPage.registerOverlay(new OptionsPage(
- 'detailsInternetPage',
- 'detailsInternetPage',
- 'detailsInternetPage'));
- }
-
var languageModifierKeysOverlay = new OptionsPage(
'languageCustomizeModifierKeysOverlay',
localStrings.getString('languageCustomizeModifierKeysOverlay'),
@@ -325,7 +295,6 @@ window.onpopstate = function(e) {
<include src="options/chromeos_language_hangul_options.html">
<include src="options/chromeos_language_mozc_options.html">
<include src="options/chromeos_language_pinyin_options.html">
- <include src="options/chromeos_labs.html">
<include src="options/chromeos_accounts_options.html">
<include src="options/chromeos_proxy.html">
</if>
« no previous file with comments | « chrome/browser/dom_ui/options/options_ui.cc ('k') | chrome/browser/resources/options/chromeos_labs.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698