Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/options.html

Issue 5025001: Removed Labs section from Chrome OS settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added labs to about:flags page Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/dom_ui/options/options_ui.cc ('k') | chrome/browser/resources/options/chromeos_labs.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html 2 <html
3 i18n-values="dir:textdirection; 3 i18n-values="dir:textdirection;
4 enable-background-mode:enable-background-mode; 4 enable-background-mode:enable-background-mode;
5 enable-cloud-print-proxy:enable-cloud-print-proxy" 5 enable-cloud-print-proxy:enable-cloud-print-proxy"
6 id="t"> 6 id="t">
7 <head> 7 <head>
8 <meta charset="utf-8"> 8 <meta charset="utf-8">
9 <title i18n-content="title"></title> 9 <title i18n-content="title"></title>
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 OptionsPage.registerOverlay(CertificateImportErrorOverlay.getInstance()); 185 OptionsPage.registerOverlay(CertificateImportErrorOverlay.getInstance());
186 } 186 }
187 OptionsPage.registerOverlay(AddStartupPageOverlay.getInstance()); 187 OptionsPage.registerOverlay(AddStartupPageOverlay.getInstance());
188 OptionsPage.registerOverlay(AlertOverlay.getInstance()); 188 OptionsPage.registerOverlay(AlertOverlay.getInstance());
189 OptionsPage.registerOverlay(AutoFillEditAddressOverlay.getInstance()); 189 OptionsPage.registerOverlay(AutoFillEditAddressOverlay.getInstance());
190 OptionsPage.registerOverlay(AutoFillEditCreditCardOverlay.getInstance()); 190 OptionsPage.registerOverlay(AutoFillEditCreditCardOverlay.getInstance());
191 OptionsPage.registerOverlay(ClearBrowserDataOverlay.getInstance()); 191 OptionsPage.registerOverlay(ClearBrowserDataOverlay.getInstance());
192 OptionsPage.registerOverlay(EditSearchEngineOverlay.getInstance()); 192 OptionsPage.registerOverlay(EditSearchEngineOverlay.getInstance());
193 OptionsPage.registerOverlay(ImportDataOverlay.getInstance()); 193 OptionsPage.registerOverlay(ImportDataOverlay.getInstance());
194 OptionsPage.registerOverlay(InstantConfirmOverlay.getInstance()); 194 OptionsPage.registerOverlay(InstantConfirmOverlay.getInstance());
195 195
arv (Not doing code reviews) 2010/11/15 20:55:20 I don't understand why you are removing these?
whywhat 2010/11/15 21:03:29 I'm removing Labs section under chrome://settings.
196 if (cr.isChromeOS) {
197 OptionsPage.register(AccountsOptions.getInstance());
198 var labsOptions = new OptionsPage('labs',
199 localStrings.getString('labsPage'),
200 'labsPage');
201 OptionsPage.register(labsOptions);
zel 2010/11/15 22:03:14 only 198-201 should be removed here, the rest of t
whywhat 2010/11/15 22:41:50 Ok, I guess my assumption that registerSubPage mea
202 OptionsPage.registerSubPage(LanguageOptions.getInstance());
203 OptionsPage.registerSubPage(new OptionsPage(
204 'languageChewing',
205 localStrings.getString('languageChewingPage'),
206 'languageChewingPage'));
207 OptionsPage.registerSubPage(new OptionsPage(
208 'languageHangul',
209 localStrings.getString('languageHangulPage'),
210 'languageHangulPage'));
211 OptionsPage.registerSubPage(new OptionsPage(
212 'languageMozc',
213 localStrings.getString('languageMozcPage'),
214 'languageMozcPage'));
215 OptionsPage.registerSubPage(new OptionsPage(
216 'languagePinyin',
217 localStrings.getString('languagePinyinPage'),
218 'languagePinyinPage'));
219 OptionsPage.registerSubPage(ProxyOptions.getInstance());
220 OptionsPage.registerOverlay(new OptionsPage(
221 'detailsInternetPage',
222 'detailsInternetPage',
223 'detailsInternetPage'));
224 }
225
226 var languageModifierKeysOverlay = new OptionsPage( 196 var languageModifierKeysOverlay = new OptionsPage(
227 'languageCustomizeModifierKeysOverlay', 197 'languageCustomizeModifierKeysOverlay',
228 localStrings.getString('languageCustomizeModifierKeysOverlay'), 198 localStrings.getString('languageCustomizeModifierKeysOverlay'),
229 'languageCustomizeModifierKeysOverlay') 199 'languageCustomizeModifierKeysOverlay')
230 OptionsPage.registerOverlay(languageModifierKeysOverlay); 200 OptionsPage.registerOverlay(languageModifierKeysOverlay);
231 201
232 Preferences.getInstance().initialize(); 202 Preferences.getInstance().initialize();
233 OptionsPage.initialize(); 203 OptionsPage.initialize();
234 204
235 var path = document.location.pathname; 205 var path = document.location.pathname;
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 <div id="mainview-content"> 288 <div id="mainview-content">
319 <if expr="pp_ifdef('chromeos')"> 289 <if expr="pp_ifdef('chromeos')">
320 <include src="options/about_page.html"> 290 <include src="options/about_page.html">
321 <include src="options/chromeos_system_options.html"> 291 <include src="options/chromeos_system_options.html">
322 <include src="options/chromeos_internet_options.html"> 292 <include src="options/chromeos_internet_options.html">
323 <include src="options/chromeos_language_options.html"> 293 <include src="options/chromeos_language_options.html">
324 <include src="options/chromeos_language_chewing_options.html"> 294 <include src="options/chromeos_language_chewing_options.html">
325 <include src="options/chromeos_language_hangul_options.html"> 295 <include src="options/chromeos_language_hangul_options.html">
326 <include src="options/chromeos_language_mozc_options.html"> 296 <include src="options/chromeos_language_mozc_options.html">
327 <include src="options/chromeos_language_pinyin_options.html"> 297 <include src="options/chromeos_language_pinyin_options.html">
328 <include src="options/chromeos_labs.html">
329 <include src="options/chromeos_accounts_options.html"> 298 <include src="options/chromeos_accounts_options.html">
330 <include src="options/chromeos_proxy.html"> 299 <include src="options/chromeos_proxy.html">
331 </if> 300 </if>
332 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')"> 301 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')">
333 <include src="options/certificate_manager.html"> 302 <include src="options/certificate_manager.html">
334 </if> 303 </if>
335 <include src="options/advanced_options.html"> 304 <include src="options/advanced_options.html">
336 <include src="options/autofill_options.html"> 305 <include src="options/autofill_options.html">
337 <include src="options/browser_options.html"> 306 <include src="options/browser_options.html">
338 <include src="options/content_settings.html"> 307 <include src="options/content_settings.html">
(...skipping 17 matching lines...) Expand all
356 cr.ui.decorate('input[pref][type=text]', options.PrefTextField); 325 cr.ui.decorate('input[pref][type=text]', options.PrefTextField);
357 cr.ui.decorate('input[pref][type=url]', options.PrefTextField); 326 cr.ui.decorate('input[pref][type=url]', options.PrefTextField);
358 cr.ui.decorate('#contentSettingsPage input[type=radio]', 327 cr.ui.decorate('#contentSettingsPage input[type=radio]',
359 options.ContentSettingsRadio); 328 options.ContentSettingsRadio);
360 cr.ui.decorate('#fontSettingsMinimumSizeSelector', 329 cr.ui.decorate('#fontSettingsMinimumSizeSelector',
361 options.MinimumFontSizeSelect); 330 options.MinimumFontSizeSelect);
362 console.log('in bottom script'); 331 console.log('in bottom script');
363 </script> 332 </script>
364 </body> 333 </body>
365 </html> 334 </html>
OLDNEW
« no previous file with comments | « chrome/browser/dom_ui/options/options_ui.cc ('k') | chrome/browser/resources/options/chromeos_labs.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698