Issue 5025: Scrolling through tabs by using mouse-wheel on tab bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5025: Scrolling through tabs by using mouse-wheel on tab bar

Created:
12 years, 2 months ago by yarin

Modified:
9 years ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Allows scrolling through the tabs by pointing at the tab bar, then scrolling the mouse-wheel. Also renames TabStrip::resize_layout_scheduled_ to needs_resize_layout_, as requested by beng. BUG=1316

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -36 lines)			Patch
M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	1 2 3	9 chunks	+47 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yarin

got lgtm from 'wcn' at #chromium-dev, still in need for an official reviewer. thanks! http://codereview.chromium.org/5025/diff/207/8 ...

12 years, 2 months ago (2008-09-28 00:09:00 UTC) #2

Ben Goodger (Google)

12 years, 2 months ago (2008-10-08 19:58:06 UTC) #3

I'm not sure we want to do this just yet. See my comment in the bug.

Expand Messages | Collapse Messages