dom-ui settings: prefer to add/remove class 'hidden' rather than manipulate t...

chrome/browser/resources/options/options_page.js

Index: chrome/browser/resources/options/options_page.js
===================================================================
--- chrome/browser/resources/options/options_page.js	(revision 66306)
+++ chrome/browser/resources/options/options_page.js	(working copy)
@@ -109,8 +109,11 @@
         pageInfo.page.visible = false;
         // Since the managed pref banner lives outside the overlay, and the
         // parent is not changing visibility, update the banner explicitly.
-        var banner = $('managed-prefs-banner');
-        banner.style.display = pageInfo.parentPage.managed ? 'block' : 'none';
+        if (pageInfo.parentPage.managed) {
+          $('managed-prefs-banner').classList.remove('hidden');
+        } else {
+          $('managed-prefs-banner').classList.add('hidden');
+        }

[stuartmorgan, 2010/11/16 23:42:55]

Since we have this duplicated three times, how about moving it to an instance
method in OptionsPage to update the banner?

[csilv, 2010/11/17 00:15:24]

Done.

       }
     }
   };
@@ -232,7 +235,11 @@
     setManagedBannerVisibility: function(visible) {
       this.managed = visible;
       if (this.visible) {
-        $('managed-prefs-banner').style.display = visible ? 'block' : 'none';
+        if (this.managed) {
+          $('managed-prefs-banner').classList.remove('hidden');
+        } else {
+          $('managed-prefs-banner').classList.add('hidden');
+        }
       }
     },
 
@@ -253,18 +260,20 @@
         return;
 
       if (visible) {
-        this.pageDiv.style.display = 'block';
+        this.pageDiv.classList.remove('hidden');
         if (this.isOverlay) {
-          var overlay = $('overlay');
-          overlay.classList.remove('hidden');
+          $('overlay').classList.remove('hidden');
           document.addEventListener('keydown',
                                     OptionsPage.clearOverlaysOnEsc_);
         } else {
           if (this.isSubPageSheet)
             $('subpage-sheet-container').classList.remove('hidden');
 
-          var banner = $('managed-prefs-banner');
-          banner.style.display = this.managed ? 'block' : 'none';
+          if (this.managed) {
+            $('managed-prefs-banner').classList.remove('hidden');
+          } else {
+            $('managed-prefs-banner').classList.add('hidden');
+          }
 
           // Recent webkit change no longer allows url change from "chrome://".
           window.history.pushState({pageName: this.name},
@@ -274,15 +283,14 @@
           this.tab.classList.add('navbar-item-selected');
         }
       } else {
+        this.pageDiv.classList.add('hidden');
         if (this.isOverlay) {
-          var overlay = $('overlay');
-          overlay.classList.add('hidden');
+          $('overlay').classList.add('hidden');
           document.removeEventListener('keydown',
                                        OptionsPage.clearOverlaysOnEsc_);
         } else if (this.isSubPageSheet) {
           $('subpage-sheet-container').classList.add('hidden');
         }
-        this.pageDiv.style.display = 'none';
         if (this.tab) {
           this.tab.classList.remove('navbar-item-selected');
         }