Issue 5024004: dom-ui settings: prefer to add/remove class 'hidden' rather than manipulate t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5024004: dom-ui settings: prefer to add/remove class 'hidden' rather than manipulate t... (Closed)

Created:
10 years, 1 month ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui settings: prefer to add/remove class 'hidden' rather than manipulate the style. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66348

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -14 lines)			Patch
	M	chrome/browser/resources/options/options_page.js	View	1	4 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

+stuartmorgan for review This is a minor improvement based on our conversation yesterday.

10 years, 1 month ago (2010-11-16 23:38:50 UTC) #1

stuartmorgan

http://codereview.chromium.org/5024004/diff/1/chrome/browser/resources/options/options_page.js File chrome/browser/resources/options/options_page.js (right): http://codereview.chromium.org/5024004/diff/1/chrome/browser/resources/options/options_page.js#newcode116 chrome/browser/resources/options/options_page.js:116: } Since we have this duplicated three times, how ...

10 years, 1 month ago (2010-11-16 23:42:55 UTC) #2