Reland r65996. Disallows Singletons on non-joinable thread.

base/platform_thread_win.cc

Index: base/platform_thread_win.cc
diff --git a/base/platform_thread_win.cc b/base/platform_thread_win.cc
index a4a1b5218808b84e05c34adab972618cd0fd1d5b..ce865dae48f724ce92f1765f4a5ad5c41856998a 100644
--- a/base/platform_thread_win.cc
+++ b/base/platform_thread_win.cc
@@ -5,6 +5,7 @@
 #include "base/platform_thread.h"
 
 #include "base/logging.h"
+#include "base/thread_restrictions.h"
 #include "base/win/windows_version.h"
 
 namespace {
@@ -20,9 +21,17 @@ typedef struct tagTHREADNAME_INFO {
   DWORD dwFlags;  // Reserved for future use, must be zero.
 } THREADNAME_INFO;
 
-DWORD __stdcall ThreadFunc(void* closure) {
-  PlatformThread::Delegate* delegate =
-      static_cast<PlatformThread::Delegate*>(closure);
+struct ThreadParams {
+  PlatformThread::Delegate* delegate;
+  bool joinable;
+};
+
+DWORD __stdcall ThreadFunc(void* params) {
+  ThreadParams* thread_params = static_cast<ThreadParams*>(params);
+  PlatformThread::Delegate* delegate = thread_params->delegate;
+  if (!thread_params->joinable)
+    base::ThreadRestrictions::SetSingletonAllowed(false);
+  delete thread_params;
   delegate->ThreadMain();
   return NULL;
 }
@@ -66,7 +75,8 @@ void PlatformThread::SetName(const char* name) {
 
 // static
 bool PlatformThread::Create(size_t stack_size, Delegate* delegate,

[wtc, 2010/11/17 01:56:18]

You should document that passing out_thread_handle=NULL to
Create() to create a non-joinable thread is for internal
use only.  The public way to create a non-joinable thread is
the CreateNonJoinable method.

[willchan no longer on Chromium, 2010/11/17 19:03:28]

Thanks for pointing this out.  I guess I missed this from the previous review :(
 Sorry!  I don't want to change the API.  So I refactored the body into a
CreateThreadInternal() function and added a DCHECK to make sure thread_handle !=
NULL in the public API.  Please take another look.

-                            PlatformThreadHandle* thread_handle) {
+                            PlatformThreadHandle* out_thread_handle) {
+  PlatformThreadHandle thread_handle;
   unsigned int flags = 0;
   if (stack_size > 0 && base::win::GetVersion() >= base::win::VERSION_XP) {
     flags = STACK_SIZE_PARAM_IS_A_RESERVATION;
@@ -74,22 +84,32 @@ bool PlatformThread::Create(size_t stack_size, Delegate* delegate,
     stack_size = 0;
   }
 
+  ThreadParams* params = new ThreadParams;
+  params->delegate = delegate;
+  params->joinable = out_thread_handle != NULL;
+
   // Using CreateThread here vs _beginthreadex makes thread creation a bit
   // faster and doesn't require the loader lock to be available.  Our code will
   // have to work running on CreateThread() threads anyway, since we run code
   // on the Windows thread pool, etc.  For some background on the difference:
   //   http://www.microsoft.com/msj/1099/win32/win321099.aspx
-  *thread_handle = CreateThread(
-      NULL, stack_size, ThreadFunc, delegate, flags, NULL);
-  return *thread_handle != NULL;
+  thread_handle = CreateThread(
+      NULL, stack_size, ThreadFunc, params, flags, NULL);
+  if (!thread_handle) {
+    delete params;
+    return false;
+  }
+
+  if (out_thread_handle)
+    *out_thread_handle = thread_handle;
+  else
+    CloseHandle(thread_handle);
+  return true;
 }
 
 // static
 bool PlatformThread::CreateNonJoinable(size_t stack_size, Delegate* delegate) {
-  PlatformThreadHandle thread_handle;
-  bool result = Create(stack_size, delegate, &thread_handle);
-  CloseHandle(thread_handle);
-  return result;
+  return Create(stack_size, delegate, NULL);
 }
 
 // static