Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 5023001: Handful of related instant changes: (Closed)

Created:
10 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Handful of related instant changes: . Makes the code for running the promo more real. We're not ready to flip it on yet, so it isn't enabled. . Nukes verbatim from about:flags and instead randomly chooses verbatim/predictive when the user opts in. We're doing this to try and see if we get feedback as to which one folks like more. Windows preferences shows you which one you get (by way of an obscure label). I'll change gtk do to that shortly too. . Adds metrics. And a couple of random style issues I encountered in some files. BUG=NONE TEST=NONE

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 3

Patch Set 3 : Fix linux build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -143 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/gtk/instant_confirm_dialog_gtk.cc View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/gtk/options/general_page_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_confirm_dialog.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_confirm_dialog.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.h View 1 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.cc View 3 chunks +109 lines, -19 lines 0 comments Download
D chrome/browser/instant/instant_opt_in.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/instant/instant_opt_in.cc View 1 chunk +0 lines, -33 lines 0 comments Download
A chrome/browser/instant/promo_counter.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/instant/promo_counter.cc View 1 chunk +115 lines, -0 lines 0 comments Download
A chrome/browser/instant/promo_counter_unittest.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M chrome/browser/profile.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/profile.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profile_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profile_impl.cc View 1 5 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 7 chunks +34 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobars.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/options/general_page_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/options/general_page_view.cc View 8 chunks +27 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.h View 2 chunks +5 lines, -3 lines 0 comments Download
M views/background.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
10 years, 1 month ago (2010-11-15 18:12:44 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/5023001/diff/2001/chrome/browser/instant/instant_controller.cc File chrome/browser/instant/instant_controller.cc (right): http://codereview.chromium.org/5023001/diff/2001/chrome/browser/instant/instant_controller.cc#newcode46 chrome/browser/instant/instant_controller.cc:46: // kInstantWasEnabledOnce was added after instant, set it ...
10 years, 1 month ago (2010-11-15 19:59:23 UTC) #2
sky
10 years, 1 month ago (2010-11-15 20:15:26 UTC) #3
http://codereview.chromium.org/5023001/diff/2001/chrome/browser/instant/insta...
File chrome/browser/instant/instant_controller.cc (right):

http://codereview.chromium.org/5023001/diff/2001/chrome/browser/instant/insta...
chrome/browser/instant/instant_controller.cc:82:
UMA_HISTOGRAM_CUSTOM_COUNTS(name, delta.InHours(), 1, 30 * 24, 50);
On 2010/11/15 19:59:23, Evan Stade wrote:
> so the idea is we're tracking how long people leave it enabled?

Yes.

Powered by Google App Engine
This is Rietveld 408576698