Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 502100: When promoting objects during a copying collection, promote all... (Closed)

Created:
11 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

When promoting objects during a copying collection, promote all non-large objects that cannot contain non-map-word pointers to other heap objects into the old data space. Committed: http://code.google.com/p/v8/source/detail?r=3519

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -35 lines) Patch
M src/heap.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/heap-inl.h View 1 chunk +17 lines, -6 lines 0 comments Download
M src/objects.h View 5 chunks +34 lines, -23 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I've reordered the instance types to make the promotion-space decision fast.
11 years ago (2009-12-22 12:48:14 UTC) #1
Erik Corry
11 years ago (2009-12-22 13:10:59 UTC) #2
LGTM
Nice cleanup.

Powered by Google App Engine
This is Rietveld 408576698