Issue 502097: Fixed deadlocks occurring in Chrome during O3D teardown when O3D is in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502097: Fixed deadlocks occurring in Chrome during O3D teardown when O3D is in... (Closed)

Created:
11 years ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
gman1, greggman, apatrick, apatrick_chromium

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fixed deadlocks occurring in Chrome during O3D teardown when O3D is in full-screen mode and another plugin on the page is making an NPAPI call. Deferred O3D's window destruction to work around this issue. Tested O3D and related tests in all browsers; this fixes the deadlock and seems to not introduce any other instability. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35134

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	plugin/win/main_win.cc	View		2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages