Move two generic string split functions from sync API to their own API in bas...

base/string_split.h

Index: base/string_split.h
===================================================================
--- base/string_split.h	(revision 0)
+++ base/string_split.h	(revision 0)
@@ -0,0 +1,27 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_STRING_SPLIT_H_
+#define BASE_STRING_SPLIT_H_
+
+#include <string>
+#include <utility>
+#include <vector>
+
+namespace base {
+
+bool SplitStringIntoKeyValues(
+    const std::string& line,
+    char key_value_delimiter,
+    std::string* key, std::vector<std::string>* values);

[Denis Lagno, 2011/03/24 15:49:20]

I have concerns about these
First problem is its weird signature:

bool SplitStringIntoKeyValues(
    const std::string& line,
    char key_value_delimiter,
    std::string* key, std::vector<std::string>* values);

contrary to this signature function splits string into single key and single
value.  Probably sometime emptiness of output vector served as error code but
now it has separate error return value.
Ok, that's easy to fix.  But there are other problems:

It accepts empty keys while rejects empty values.  For me it sounds weird: empty
values are common and normal but empty key usually means that something is
broken.
How it handles multiple delimiters like in "key===value=" -- it splits it as
"key" and "value=" -- this looks not great, I prefer "key" and "==value="
because it does not place unnecessary restriction (do not start with delimiter)
on value strings.  And BTW it does not check multiple delimiters in unittests:)

Currently those functions are used only in gaia auth, so I fear to break
something by changing it but in its current form I doubt this split string
functionality is usable by general public (as implied by its presence in base::)

+
+bool SplitStringIntoKeyValuePairs(
+    const std::string& line,
+    char key_value_delimiter,
+    char key_value_pair_delimiter,
+    std::vector<std::pair<std::string, std::string> >* kv_pairs);
+
+}  // namespace base
+
+#endif  // BASE_STRING_SPLIT_H
Property changes on: base\string_split.h
___________________________________________________________________
Added: svn:eol-style
   + LF