Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: net/proxy/proxy_list.h

Issue 502068: Remove the implicit fallback to DIRECT when proxies fail. This better matches... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Fix a comment typo Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_list.h
===================================================================
--- net/proxy/proxy_list.h (revision 35522)
+++ net/proxy/proxy_list.h (working copy)
@@ -32,9 +32,13 @@
// |scheme_bit_field| is a bunch of ProxyServer::Scheme bitwise ORed together.
void RemoveProxiesWithoutScheme(int scheme_bit_field);
- // Returns the first valid proxy server in the list.
- ProxyServer Get() const;
+ // Returns true if there is nothing left in the ProxyList.
+ bool IsEmpty() const;
+ // Returns the first proxy server in the list. It is only valid to call
+ // this if !IsEmpty().
+ const ProxyServer& Get() const;
+
// Set the list by parsing the pac result |pac_string|.
// Some examples for |pac_string|:
// "DIRECT"

Powered by Google App Engine
This is Rietveld 408576698