Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: net/proxy/proxy_service.h

Issue 502068: Remove the implicit fallback to DIRECT when proxies fail. This better matches... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Fix a comment typo Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_service.h
===================================================================
--- net/proxy/proxy_service.h (revision 35522)
+++ net/proxy/proxy_service.h (working copy)
@@ -222,12 +222,6 @@
// Removes |req| from the list of pending requests.
void RemovePendingRequest(PacRequest* req);
- // Called to indicate that a PacRequest completed. The |config_id| parameter
- // indicates the proxy configuration that was queried. |result_code| is OK
- // if the PAC file could be downloaded and executed. Otherwise, it is an
- // error code, indicating a bad proxy configuration.
- void DidCompletePacRequest(int config_id, int result_code);
-
// Returns true if the URL passed in should not go through the proxy server.
// 1. If the proxy settings say to bypass local names, and |IsLocalName(url)|.
// 2. The URL matches one of the entities in the proxy bypass list.
@@ -253,9 +247,6 @@
// Increasing ID to give to the next ProxyConfig that we set.
int next_config_id_;
- // Indicates that the configuration is bad and should be ignored.
- bool config_is_bad_;
-
// Indicates whether the ProxyResolver should be sent requests.
bool should_use_proxy_resolver_;

Powered by Google App Engine
This is Rietveld 408576698