Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 502068: Remove the implicit fallback to DIRECT when proxies fail. This better matches... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Fix a comment typo Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
===================================================================
--- net/http/http_network_transaction_unittest.cc (revision 35522)
+++ net/http/http_network_transaction_unittest.cc (working copy)
@@ -3556,6 +3556,8 @@
SessionDependencies session_deps(
CreateFixedProxyService("myproxy:70;foobar:80"));
+ // This simulates failure resolving all hostnames; that means we will fail
+ // connecting to both proxies (myproxy:70 and foobar:80).
session_deps.host_resolver->rules()->AddSimulatedFailure("*");
scoped_ptr<HttpTransaction> trans(

Powered by Google App Engine
This is Rietveld 408576698