Issue 502067: - Handle HeapNumbers in deferred code instead of jumping to stub...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502067: - Handle HeapNumbers in deferred code instead of jumping to stub... (Closed)

Created:
11 years ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Handle HeapNumbers in deferred code instead of jumping to stub for DeferredInlineBinaryOperations. Committed: http://code.google.com/p/v8/source/detail?r=3486

Patch Set 1 #

Total comments: 5

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+74 lines, -0 lines	5 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years ago (2009-12-18 07:23:13 UTC) #2

LGTM, but we should probably spend a few minutes looking at the code size impact
of this change (seems to be +2.8% on V8 benchmarks).

http://codereview.chromium.org/502067/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/502067/diff/1/2#newcode841
src/ia32/codegen-ia32.cc:841: __ sar(left_, 1);
1 -> kSmiTagSize

http://codereview.chromium.org/502067/diff/1/2#newcode843
src/ia32/codegen-ia32.cc:843: __ shl(left_, 1);
1 -> kSmiTagSize

http://codereview.chromium.org/502067/diff/1/2#newcode869
src/ia32/codegen-ia32.cc:869: __ sar(right_, 1);
1 -> kSmiTagSize

http://codereview.chromium.org/502067/diff/1/2#newcode871
src/ia32/codegen-ia32.cc:871: __ shl(right_, 1);
1 -> kSmiTagSize

http://codereview.chromium.org/502067/diff/1/2#newcode888
src/ia32/codegen-ia32.cc:888: __ jmp(&done);
Could this be a jmp(exit_label())?

Expand Messages | Collapse Messages