Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 502014: Add a script for creating a VirtualBox image. (Closed)

Created:
11 years ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Add a script for creating a VirtualBox image. Issue 1027 (http://code.google.com/p/chromium-os/issues/detail?id=1027)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added check to make sure that qemu-img and VBoxManage exist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
A src/scripts/image_to_virtualbox.sh View 1 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gauravsh
Basically a slight modification of the image_to_vmware.sh script.
11 years ago (2009-12-15 22:03:26 UTC) #1
sosa
lgtm except for one comment http://codereview.chromium.org/502014/diff/1/2 File src/scripts/image_to_virtualbox.sh (right): http://codereview.chromium.org/502014/diff/1/2#newcode51 src/scripts/image_to_virtualbox.sh:51: VBoxManage convertdd "${TEMP_IMAGE}" "${FLAGS_to}" ...
11 years ago (2009-12-15 22:51:13 UTC) #2
gauravsh
11 years ago (2009-12-15 23:35:20 UTC) #3
http://codereview.chromium.org/502014/diff/1/2
File src/scripts/image_to_virtualbox.sh (right):

http://codereview.chromium.org/502014/diff/1/2#newcode51
src/scripts/image_to_virtualbox.sh:51: VBoxManage convertdd "${TEMP_IMAGE}"
"${FLAGS_to}"
On 2009/12/15 22:51:13, sosa wrote:
> You may wanna test for Virtual box installed early on to abort early if VBox
is
> not installed

Good point. I have added a check.

Powered by Google App Engine
This is Rietveld 408576698