Don't call NP_Shutdown in FreePluginLibraryTask if the library has already been reloaded.

Don't call NP_Shutdown in FreePluginLibraryTask if the library has already been reloaded.

BUG=63213
TEST=PluginTest.ForceReload


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66269

[Marshall, 2010-11-15 17:17:53]

Please review.

[jam, 2010-11-15 17:35:34]

can you add a test to webkit/tools/test_shell/plugin_tests.cc?

[Marshall, 2010-11-15 17:44:58]

On 2010/11/15 17:35:34, John Abd-El-Malek wrote:
> can you add a test to webkit/tools/test_shell/plugin_tests.cc?

I'm not sure how to write a test for this without using the Flash plugin. Would
that be OK?

[jam, 2010-11-15 17:59:11]

Check out the other tests in that file, they use a testing plugin (
TEST_PLUGIN_NAME).  You should be able to write a test using that instead of
Flash.

On Mon, Nov 15, 2010 at 9:44 AM, <marshall@chromium.org> wrote:

> On 2010/11/15 17:35:34, John Abd-El-Malek wrote:
>
>> can you add a test to webkit/tools/test_shell/plugin_tests.cc?
>>
>
> I'm not sure how to write a test for this without using the Flash plugin.
> Would
> that be OK?
>
>
> http://codereview.chromium.org/5020001/
>

[Marshall, 2010-11-15 18:43:30]

On 2010/11/15 17:59:11, John Abd-El-Malek wrote:
> Check out the other tests in that file, they use a testing plugin (
> TEST_PLUGIN_NAME).  You should be able to write a test using that instead of
> Flash.

To exercise the bug I need to load the plugin, unload the plugin and then
re-load the plugin all in the same page.  Is there a way to force the plugin to
be unloaded using JavaScript or similar?

[Marshall, 2010-11-15 19:19:04]

On 2010/11/15 18:43:30, Marshall wrote:
> To exercise the bug I need to load the plugin, unload the plugin and then
> re-load the plugin all in the same page.  Is there a way to force the plugin
to
> be unloaded using JavaScript or similar?

Never mind, I figured it out :-). Please review.

[jam, 2010-11-15 19:19:20]

On Mon, Nov 15, 2010 at 10:43 AM, <marshall@chromium.org> wrote:

> On 2010/11/15 17:59:11, John Abd-El-Malek wrote:
>
>> Check out the other tests in that file, they use a testing plugin (
>> TEST_PLUGIN_NAME).  You should be able to write a test using that instead
>> of
>> Flash.
>>
>
> To exercise the bug I need to load the plugin, unload the plugin and then
> re-load the plugin all in the same page.  Is there a way to force the
> plugin to
> be unloaded using JavaScript or similar?


you can remove the plugin node through JS..

>
>
>
> http://codereview.chromium.org/5020001/
>

[jam, 2010-11-15 19:20:26]

lgtm

[Marshall, 2010-11-15 21:20:24]

On 2010/11/15 19:20:26, John Abd-El-Malek wrote:
> lgtm

I changed the implementation a bit to fix a library reference counting problem
on Windows.

[jam, 2010-11-15 21:30:18]

lgtm

On Mon, Nov 15, 2010 at 1:20 PM, <marshall@chromium.org> wrote:

> On 2010/11/15 19:20:26, John Abd-El-Malek wrote:
>
>> lgtm
>>
>
> I changed the implementation a bit to fix a library reference counting
> problem
> on Windows.
>
>
> http://codereview.chromium.org/5020001/
>