Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 5020001: Don't call NP_Shutdown in FreePluginLibraryTask if the library has already been reloaded. (Closed)

Created:
10 years, 1 month ago by Marshall
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Don't call NP_Shutdown in FreePluginLibraryTask if the library has already been reloaded. BUG=63213 TEST=PluginTest.ForceReload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66269

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
A webkit/data/plugins/force_reload.html View 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.cc View 1 2 2 chunks +22 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 2 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Marshall
Please review.
10 years, 1 month ago (2010-11-15 17:17:53 UTC) #1
jam
can you add a test to webkit/tools/test_shell/plugin_tests.cc?
10 years, 1 month ago (2010-11-15 17:35:34 UTC) #2
Marshall
On 2010/11/15 17:35:34, John Abd-El-Malek wrote: > can you add a test to webkit/tools/test_shell/plugin_tests.cc? I'm ...
10 years, 1 month ago (2010-11-15 17:44:58 UTC) #3
jam
Check out the other tests in that file, they use a testing plugin ( TEST_PLUGIN_NAME). ...
10 years, 1 month ago (2010-11-15 17:59:11 UTC) #4
Marshall
On 2010/11/15 17:59:11, John Abd-El-Malek wrote: > Check out the other tests in that file, ...
10 years, 1 month ago (2010-11-15 18:43:30 UTC) #5
Marshall
On 2010/11/15 18:43:30, Marshall wrote: > To exercise the bug I need to load the ...
10 years, 1 month ago (2010-11-15 19:19:04 UTC) #6
jam
On Mon, Nov 15, 2010 at 10:43 AM, <marshall@chromium.org> wrote: > On 2010/11/15 17:59:11, John ...
10 years, 1 month ago (2010-11-15 19:19:20 UTC) #7
jam
lgtm
10 years, 1 month ago (2010-11-15 19:20:26 UTC) #8
Marshall
On 2010/11/15 19:20:26, John Abd-El-Malek wrote: > lgtm I changed the implementation a bit to ...
10 years, 1 month ago (2010-11-15 21:20:24 UTC) #9
jam
10 years, 1 month ago (2010-11-15 21:30:18 UTC) #10
lgtm

On Mon, Nov 15, 2010 at 1:20 PM, <marshall@chromium.org> wrote:

> On 2010/11/15 19:20:26, John Abd-El-Malek wrote:
>
>> lgtm
>>
>
> I changed the implementation a bit to fix a library reference counting
> problem
> on Windows.
>
>
> http://codereview.chromium.org/5020001/
>

Powered by Google App Engine
This is Rietveld 408576698