Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 5019005: Add "open as window" menu item to NTP app menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase for commit Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_service.h ('k') | chrome/browser/resources/new_new_tab.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.cc
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index 06fe0687551e60f658171c20d7ae2d9920fda1d5..02c4bcca0b3415527fec18024161d0337310ed9c 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -607,7 +607,7 @@ void ExtensionsService::InitEventRouters() {
void ExtensionsService::Init() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK(!ready_);
+ DCHECK(!ready_); // Can't redo init.
DCHECK_EQ(extensions_.size(), 0u);
// Hack: we need to ensure the ResourceDispatcherHost is ready before we load
@@ -1483,10 +1483,11 @@ void ExtensionsService::GarbageCollectExtensions() {
}
void ExtensionsService::OnLoadedInstalledExtensions() {
- ready_ = true;
if (updater_.get()) {
updater_->Start();
}
+
+ ready_ = true;
NotificationService::current()->Notify(
NotificationType::EXTENSIONS_READY,
Source<Profile>(profile_),
« no previous file with comments | « chrome/browser/extensions/extensions_service.h ('k') | chrome/browser/resources/new_new_tab.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698