chrome/browser/tab_contents/tab_contents.cc - Issue 5019005: Add "open as window" menu item to NTP app menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 5019005: Add "open as window" menu item to NTP app menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/tab_contents.cc

diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc

index 26b77ce1255e1faf5e9013cf9f5ab3a0b5b4f355..8960d27527b51d6d7ca58d8f836153232cd08d88 100644

--- a/chrome/browser/tab_contents/tab_contents.cc

+++ b/chrome/browser/tab_contents/tab_contents.cc

@@ -605,7 +605,7 @@ void TabContents::SetExtensionAppById(const std::string& extension_app_id) {

return;

ExtensionsService* extension_service = profile()->GetExtensionsService();

- if (extension_service && extension_service->is_ready()) {

+ if (extension_service) {

Aaron Boodman 2010/11/18 07:49:03 No need to check this here.

Sam Kerner (Chrome) 2010/11/18 15:34:01 Fixed here and several other places.

const Extension* extension =

extension_service->GetExtensionById(extension_app_id, false);

if (extension)