chrome/browser/extensions/extension_startup_browsertest.cc - Issue 5019005: Add "open as window" menu item to NTP app menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 5019005: Add "open as window" menu item to NTP app menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_startup_browsertest.cc

diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc

index 1b15ce0752bc0f363146d0a86382a86bae64b210..a5561ef86698715e42f83b9dd473469c543e2368 100644

--- a/chrome/browser/extensions/extension_startup_browsertest.cc

+++ b/chrome/browser/extensions/extension_startup_browsertest.cc

@@ -84,9 +84,6 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {

void WaitForServicesToStart(int num_expected_extensions,

bool expect_extensions_enabled) {

ExtensionsService* service = browser()->profile()->GetExtensionsService();

- if (!service->is_ready())

- ui_test_utils::WaitForNotification(NotificationType::EXTENSIONS_READY);

- ASSERT_TRUE(service->is_ready());

// Count the number of non-component extensions.

int found_extensions = 0;