Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/new_new_tab.html

Issue 5019005: Add "open as window" menu item to NTP app menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« chrome/browser/extensions/extension_dom_ui.cc ('K') | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/resources/ntp/apps.js » ('j') | chrome/browser/ui/browser.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html i18n-values=" 2 <html i18n-values="
3 dir:textdirection; 3 dir:textdirection;
4 bookmarkbarattached:bookmarkbarattached; 4 bookmarkbarattached:bookmarkbarattached;
5 hasattribution:hasattribution; 5 hasattribution:hasattribution;
6 anim:anim; 6 anim:anim;
7 syncispresent:syncispresent; 7 syncispresent:syncispresent;
8 customlogo:customlogo" 8 customlogo:customlogo"
9 install-animation-enabled="true"> 9 install-animation-enabled="true">
10 <head> 10 <head>
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 <command id="clear-all-blacklisted" i18n-values=".label:restorethumbnails"> 231 <command id="clear-all-blacklisted" i18n-values=".label:restorethumbnails">
232 <command id="apps-launch-command"> 232 <command id="apps-launch-command">
233 <command id="apps-options-command" i18n-values=".label:appoptions"> 233 <command id="apps-options-command" i18n-values=".label:appoptions">
234 <command id="apps-uninstall-command" i18n-values=".label:appuninstall"> 234 <command id="apps-uninstall-command" i18n-values=".label:appuninstall">
235 <command id="apps-launch-type-pinned" i18n-values=".label:applaunchtypepinned" 235 <command id="apps-launch-type-pinned" i18n-values=".label:applaunchtypepinned"
236 launch-type="0"> 236 launch-type="0">
237 <command id="apps-launch-type-regular" i18n-values=".label:applaunchtyperegular" 237 <command id="apps-launch-type-regular" i18n-values=".label:applaunchtyperegular"
238 launch-type="1"> 238 launch-type="1">
239 <command id="apps-launch-type-fullscreen" 239 <command id="apps-launch-type-fullscreen"
240 i18n-values=".label:applaunchtypefullscreen" launch-type="2"> 240 i18n-values=".label:applaunchtypefullscreen" launch-type="2">
241 <command id="apps-launch-type-window"
242 i18n-values=".label:applaunchtypewindow" launch-type="3">
241 243
242 <menu id="app-context-menu"> 244 <menu id="app-context-menu">
243 <button class="default" command="#apps-launch-command"></button> 245 <button class="default" command="#apps-launch-command"></button>
244 <hr> 246 <hr>
245 <button command="#apps-launch-type-regular" launch-type="1"></button> 247 <button command="#apps-launch-type-regular" launch-type="1"></button>
246 <button command="#apps-launch-type-pinned" launch-type="0"></button> 248 <button command="#apps-launch-type-pinned" launch-type="0"></button>
247 <button command="#apps-launch-type-fullscreen" launch-type="2"></button> 249 <button command="#apps-launch-type-fullscreen" launch-type="2"></button>
250 <button command="#apps-launch-type-window" launch-type="3"></button>
Aaron Boodman 2010/11/17 06:12:47 For some reason it feels to me like 'full screen'
Sam Kerner (Chrome) 2010/11/18 03:53:36 Done.
248 <hr> 251 <hr>
249 <button command="#apps-options-command"></button> 252 <button command="#apps-options-command"></button>
250 <button command="#apps-uninstall-command"></button> 253 <button command="#apps-uninstall-command"></button>
251 </menu> 254 </menu>
252 255
253 <!-- These are populated dynamically --> 256 <!-- These are populated dynamically -->
254 <menu id="apps-menu"></menu> 257 <menu id="apps-menu"></menu>
255 <menu id="most-visited-menu"></menu> 258 <menu id="most-visited-menu"></menu>
256 <menu id="recently-closed-menu"></menu> 259 <menu id="recently-closed-menu"></menu>
257 260
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS); 308 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS);
306 setSectionVisible( 309 setSectionVisible(
307 'most-visited', Section.THUMB, 310 'most-visited', Section.THUMB,
308 mostVisitedInitiallyVisible, MINIMIZED_THUMB); 311 mostVisitedInitiallyVisible, MINIMIZED_THUMB);
309 setSectionVisible( 312 setSectionVisible(
310 'recently-closed', undefined, 313 'recently-closed', undefined,
311 recentlyClosedInitiallyVisible, MINIMIZED_RECENT); 314 recentlyClosedInitiallyVisible, MINIMIZED_RECENT);
312 layoutSections(); 315 layoutSections();
313 </script> 316 </script>
314 </html> 317 </html>
OLDNEW
« chrome/browser/extensions/extension_dom_ui.cc ('K') | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/resources/ntp/apps.js » ('j') | chrome/browser/ui/browser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698