Add "open as window" menu item to NTP app menu.

chrome/browser/extensions/extension_dom_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_dom_ui.h"
 
 #include <set>
 
 #include "net/base/file_stream.h"
 #include "base/string_util.h"
@@ skipping 221 matching lines @@
 
   const DictionaryValue* overrides =
       profile->GetPrefs()->GetDictionary(kExtensionURLOverrides);
   std::string page = url->host();
   ListValue* url_list;
   if (!overrides || !overrides->GetList(page, &url_list))
     return false;
 
   ExtensionsService* service = profile->GetExtensionsService();
   if (!service->is_ready()) {
-    // TODO(erikkay) So far, it looks like extensions load before the new tab
-    // page.  I don't know if we have anything that enforces this, so add this
-    // check for safety.
     NOTREACHED() << "Chrome URL override requested before extensions loaded";

[Sam Kerner (Chrome), 2010/11/17 05:07:36]

Comment is obsolete now that extensions service loads synchronously.

[Aaron Boodman, 2010/11/17 06:12:47]

In that case, you can remove this check completely. Also, maybe we should remove
is_ready() since ExtensionsService is always ready now?

[Sam Kerner (Chrome), 2010/11/18 03:53:36]

ExtensionsService::ready_ is set to false in the extensions service constructor,
and set to true by a call to ExtensionsService::Init().  Kept the internal bool
as a way to catch multiple Init() calls.  Got rid of is_ready().

     return false;
   }
 
   size_t i = 0;
   while (i < url_list->GetSize()) {
     Value* val = NULL;
     url_list->Get(i, &val);
 
     // Verify that the override value is good.  If not, unregister it and find
     // the next one.
@@ skipping 146 matching lines @@
 }
 
 // static
 void ExtensionDOMUI::GetFaviconForURL(Profile* profile,
     FaviconService::GetFaviconRequest* request, const GURL& page_url) {
   // tracker deletes itself when done.
   ExtensionDOMUIImageLoadingTracker* tracker =
       new ExtensionDOMUIImageLoadingTracker(profile, request, page_url);
   tracker->Init();
 }