Add "open as window" menu item to NTP app menu.

chrome/browser/resources/ntp/apps.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var MAX_APPS_PER_ROW = [];
 MAX_APPS_PER_ROW[LayoutMode.SMALL] = 4;
 MAX_APPS_PER_ROW[LayoutMode.NORMAL] = 6;
 
 // The URL prefix used in the app link 'ping' attributes.
 var PING_APP_LAUNCH_PREFIX = 'record-app-launch';
 
 // The URL prefix used in the webstore link 'ping' attributes.
 var PING_WEBSTORE_LAUNCH_PREFIX = 'record-webstore-launch';
 
 function getAppsCallback(data) {
   logEvent('received apps');
   var appsSection = $('apps');
   var appsSectionContent = $('apps-content');
   var appsMiniview = appsSection.getElementsByClassName('miniview')[0];
   var appsPromo = $('apps-promo');
   var appsPromoPing = PING_WEBSTORE_LAUNCH_PREFIX + '+' + data.showPromo;
   var webStoreEntry;
 
+  // Hide the app window menu option on platforms that do not support it.
+  $('apps-launch-type-window-menu-item').style.display =

[Aaron Boodman, 2010/11/18 07:49:03]

I think it would be a little neater to just do this in JS, like:

if (navigator.platform.toLowerCase().indexOf('mac') == 0)

[Sam Kerner (Chrome), 2010/11/18 15:34:01]

What if the user changes the user agent?  This is possible today with command
line flag --user-agent.

[Aaron Boodman, 2010/11/18 16:16:00]

Good point.

[arv (Not doing code reviews), 2010/11/18 19:02:49]

If they change the user agent they are opening the flood gates...

[arv (Not doing code reviews), 2010/11/18 19:02:49]

cr.isMac

+      (data.disableAppWindowLaunch ? 'none' : 'inline');
+
   appsMiniview.textContent = '';
   appsSectionContent.textContent = '';
 
   apps.showPromo = data.showPromo;
 
   data.apps.sort(function(a,b) {
     return a.app_launch_index - b.app_launch_index;
   });
 
   clearClosedMenu(apps.menu);
@@ skipping 109 matching lines @@
   function handleClick(e) {
     var appId = e.currentTarget.getAttribute('app-id');
     launchApp(appId);
     return false;
   }
 
   // Keep in sync with LaunchType in extension_prefs.h
   var LaunchType = {
     LAUNCH_PINNED: 0,
     LAUNCH_REGULAR: 1,
-    LAUNCH_FULLSCREEN: 2
+    LAUNCH_FULLSCREEN: 2,
+    LAUNCH_WINDOW: 3
   };
 
-  // Keep in sync with LaunchContainer in extension.h
+  // Keep in sync with LaunchContainer in extension_constants.h
   var LaunchContainer = {
     LAUNCH_WINDOW: 0,
     LAUNCH_PANEL: 1,
     LAUNCH_TAB: 2
   };
 
   var currentApp;
 
   function addContextMenu(el, app) {
     el.addEventListener('contextmenu', cr.ui.contextMenuHandler);
@@ skipping 10 matching lines @@
         var appLinkSel = '.app a[app-id=' + app['id'] + ']';
         var launchType =
             el.querySelector(appLinkSel).getAttribute('launch-type');
 
         var launchContainer = app['launch_container'];
         var isPanel = launchContainer == LaunchContainer.LAUNCH_PANEL;
 
         // Update the commands related to the launch type.
         var launchTypeIds = ['apps-launch-type-pinned',
                              'apps-launch-type-regular',
-                             'apps-launch-type-fullscreen'];
+                             'apps-launch-type-fullscreen',
+                             'apps-launch-type-window'];
         launchTypeIds.forEach(function(id) {
           var command = $(id);
           command.disabled = isPanel;
           command.checked = !isPanel &&
               launchType == command.getAttribute('launch-type');
         });
 
         return $('app-context-menu');
       }
     });
@@ skipping 10 matching lines @@
         break;
       case 'apps-launch-command':
         launchApp(currentApp['id']);
         break;
       case 'apps-uninstall-command':
         chrome.send('uninstallApp', [currentApp['id']]);
         break;
       case 'apps-launch-type-pinned':
       case 'apps-launch-type-regular':
       case 'apps-launch-type-fullscreen':
+      case 'apps-launch-type-window':
         chrome.send('setLaunchType',
             [currentApp['id'], e.command.getAttribute('launch-type')]);
         break;
     }
   });
 
   document.addEventListener('canExecute', function(e) {
     switch (e.command.id) {
       case 'apps-options-command':
         e.canExecute = currentApp && currentApp['options_url'];
@@ skipping 83 matching lines @@
       var elm = createElement({
         'id': 'web-store-entry',
         'name': localStrings.getString('web_store_title'),
         'launch_url': localStrings.getString('web_store_url')
       });
       elm.setAttribute('app-id', 'web-store-entry');
       return elm;
     }
   };
 })();