Add "open as window" menu item to NTP app menu.

chrome/browser/background_application_list_model.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background_application_list_model.h"
 
 #include <algorithm>
 
 #include "app/l10n_util_collator.h"
 #include "base/stl_util-inl.h"
@@ skipping 222 matching lines @@
 
 void BackgroundApplicationListModel::Observe(
     NotificationType type,
     const NotificationSource& source,
     const NotificationDetails& details) {
   if (type == NotificationType::EXTENSIONS_READY) {
     Update();
     return;
   }
   ExtensionsService* service = profile_->GetExtensionsService();
-  if (!service || !service->is_ready())
+  if (!service)

[Aaron Boodman, 2010/11/18 07:49:03]

I do not think it is ever possible to not have an ExtensionsService instance.

[Sam Kerner (Chrome), 2010/11/18 15:34:01]

Done.

     return;
   switch (type.value) {
     case NotificationType::EXTENSION_LOADED:
       OnExtensionLoaded(Details<Extension>(details).ptr());
       break;
     case NotificationType::EXTENSION_UNLOADED:
       // Handle extension unload uniformly, falling through to next case.
     case NotificationType::EXTENSION_UNLOADED_DISABLED:
       OnExtensionUnloaded(Details<Extension>(details).ptr());
       break;
@@ skipping 25 matching lines @@
 void BackgroundApplicationListModel::RemoveObserver(Observer* observer) {
   observers_.RemoveObserver(observer);
 }
 
 // Update queries the extensions service of the profile with which the model was
 // initialized to determine the current set of background applications.  If that
 // differs from the old list, it generates OnApplicationListChanged events for
 // each observer.
 void BackgroundApplicationListModel::Update() {
   ExtensionsService* service = profile_->GetExtensionsService();
-  DCHECK(service->is_ready());
 
   // Discover current background applications, compare with previous list, which
   // is consistently sorted, and notify observers if they differ.
   ExtensionList extensions;
   GetServiceApplications(service, &extensions);
   ExtensionList::const_iterator old_cursor = extensions_.begin();
   ExtensionList::const_iterator new_cursor = extensions.begin();
   while (old_cursor != extensions_.end() &&
          new_cursor != extensions.end() &&
          (*old_cursor)->name() == (*new_cursor)->name() &&
          (*old_cursor)->id() == (*new_cursor)->id()) {
     ++old_cursor;
     ++new_cursor;
   }
   if (old_cursor != extensions_.end() || new_cursor != extensions.end()) {
     extensions_ = extensions;
     FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged());
   }
 }