Issue 5017004: Call GpuThread::Init before starting the GPU watchdog thread....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5017004: Call GpuThread::Init before starting the GPU watchdog thread.... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Call GpuThread::Init before starting the GPU watchdog thread. Collecting GPU info was taking enough time to make the GPU watchdog abort the GPU process. Moved GTK initialization into GpuProcess (but still before gfx::GLContext::InitializeOneOff). TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66333

Patch Set 1 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -34 lines)			Patch
	M	chrome/gpu/gpu_main.cc	View		5 chunks	+21 lines, -16 lines	0 comments	Download
	M	chrome/gpu/gpu_thread.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

10 years, 1 month ago (2010-11-16 21:42:08 UTC) #2

LGTM

I thought that GPU info collection was asynchronous now on the platform where it
was expensive (Windows)?

Expand Messages | Collapse Messages