Issue 5017002: Add missing dependency to nacl_sandbox_test. Win64 needs depends on a differe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5017002: Add missing dependency to nacl_sandbox_test. Win64 needs depends on a differe... (Closed)

Created:
10 years, 1 month ago by jvoung - send to chromium...

Modified:
9 years, 7 months ago

Reviewers:
nsylvain

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add missing dependency to nacl_sandbox_test. Win64 depends on a different dll. BUG=50121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66162

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 1 month ago (2010-11-15 20:35:26 UTC) #2

LGTM

On Mon, Nov 15, 2010 at 12:31 PM, <jvoung@google.com> wrote:

> Reviewers: nsylvain,
>
> Description:
> Add missing dependency to nacl_sandbox_test. Win64 depends on a different
> dll.
> BUG=50121
>
>
> Please review this at http://codereview.chromium.org/5017002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/chrome_tests.gypi
>
>
> Index: chrome/chrome_tests.gypi
> ===================================================================
> --- chrome/chrome_tests.gypi    (revision 66118)
> +++ chrome/chrome_tests.gypi    (working copy)
> @@ -828,6 +828,7 @@
>             'chrome_nacl_win64',
>             'crash_service',  # run time dependency
>             'nacl_security_tests', # run time dependency
> +            'nacl_security_tests64', # run time dependency
>             'test_support_common',
>             '../google_update/google_update.gyp:google_update',
>             '../views/views.gyp:views',
>
>
>

Expand Messages | Collapse Messages