Issue 5016001: unit_tests: Fix link error (missing libXi) on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5016001: unit_tests: Fix link error (missing libXi) on Linux (Closed)

Created:
10 years, 1 month ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
sadrul, Evan Martin, evanm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

unit_tests: Fix link error (missing libXi) on Linux unit_tests fails to link due to requirement on libXi. This is implicitly provided by 'gdk', but unit_tests does not depend on this target. We add a 'xi' dependency for any target depending on 'x11'. BUG=63209 TEST=None (Landing patch for jknotten@chromium.org.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66169

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	build/linux/system.gyp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM. I think this should go through the trybots just to make sure it doesn't ...

10 years, 1 month ago (2010-11-15 16:27:01 UTC) #2

LGTM

Expand Messages | Collapse Messages